Bug 234420

Summary: Stub out NotificationEvent and related
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, benjamin, calvaris, cdumez, cmarcelo, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, kondapallykalyan, ryuan.choi, sergio, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Does it build v1
ews-feeder: commit-queue-
Does it build v2
ews-feeder: commit-queue-
Does it build and test v1
ews-feeder: commit-queue-
Does it build and test v2
none
Patch v1
achristensen: review+
PFL none

Brady Eidson
Reported 2021-12-16 20:46:28 PST
Stub out NotificationEvent and related
Attachments
Does it build v1 (34.31 KB, patch)
2021-12-16 20:52 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Does it build v2 (35.30 KB, patch)
2021-12-17 10:14 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Does it build and test v1 (36.82 KB, patch)
2021-12-18 11:51 PST, Brady Eidson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Does it build and test v2 (36.82 KB, patch)
2021-12-18 13:33 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v1 (40.20 KB, patch)
2021-12-18 17:09 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
PFL (40.20 KB, patch)
2021-12-18 21:30 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2021-12-16 20:52:12 PST
Created attachment 447419 [details] Does it build v1
Brady Eidson
Comment 2 2021-12-17 10:14:51 PST
Created attachment 447458 [details] Does it build v2
Brady Eidson
Comment 3 2021-12-18 11:51:21 PST
Created attachment 447527 [details] Does it build and test v1
Brady Eidson
Comment 4 2021-12-18 13:33:04 PST
Created attachment 447531 [details] Does it build and test v2
Brady Eidson
Comment 5 2021-12-18 17:09:15 PST
Created attachment 447537 [details] Patch v1
Alex Christensen
Comment 6 2021-12-18 18:57:02 PST
Comment on attachment 447537 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=447537&action=review > Source/WebCore/Modules/notifications/NotificationEvent.h:58 > + nit: extra space
Brady Eidson
Comment 7 2021-12-18 21:30:21 PST
Created attachment 447539 [details] PFL
EWS
Comment 8 2021-12-19 21:04:44 PST
Committed r287253 (245411@main): <https://commits.webkit.org/245411@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447539 [details].
Radar WebKit Bug Importer
Comment 9 2021-12-19 21:05:18 PST
<rdar://problem/86708525>
Note You need to log in before you can comment on or make changes to this bug.