Bug 234372

Summary: Some webpushtool improvements
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, nham, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description Brady Eidson 2021-12-15 16:21:07 PST 
Some webpushtool improvements
Comment 1 Brady Eidson 2021-12-15 18:55:23 PST 
Created attachment 447311 [details]
Patch v1
Comment 2 Alex Christensen 2021-12-15 19:05:58 PST 
Comment on attachment 447311 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=447311&action=review

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:153
> +            CFRunLoopStop(CFRunLoopGetMain());

exit(0)?
Comment 3 Brady Eidson 2021-12-15 19:32:51 PST 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 447311 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447311&action=review
> 
> > Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:153
> > +            CFRunLoopStop(CFRunLoopGetMain());
> 
> exit(0)?

I have future vision for the next enhancement that'll involve a nested runloop 😆
Comment 4 EWS 2021-12-15 20:34:48 PST 
Committed r287125 (245309@main): <https://commits.webkit.org/245309@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447311 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-15 20:35:19 PST 
<rdar://problem/86556476>