Bug 234369

Summary:

Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Scrolling

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

NEW ---

Severity:

Normal

CC:

cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Simon Fraser (smfr) 2021-12-15 15:29:15 PST

Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree

Comment 1 Simon Fraser (smfr) 2021-12-15 15:30:31 PST

Created attachment 447291 [details]
Patch

Comment 2 Sam Weinig 2021-12-16 12:36:56 PST

Comment on attachment 447291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447291&action=review

> Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:118
> +#if PLATFORM(COCOA)
> +        platformWheelEvent = scrollingTree->wheelEventAfterFiltering(platformWheelEvent);
> +#endif

Can we have all platforms implement wheelEventAfterFiltering() (or the base class) as the identity function if they don't need to do any filtering to remove this #ifdef?

Comment 3 Radar WebKit Bug Importer 2021-12-22 15:30:18 PST

<rdar://problem/86828138>