Bug 234369

Summary: Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Simon Fraser (smfr)
Reported 2021-12-15 15:29:15 PST
Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree
Attachments
Patch (10.48 KB, patch)
2021-12-15 15:30 PST, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-12-15 15:30:31 PST
Created attachment 447291 [details] Patch
Sam Weinig
Comment 2 2021-12-16 12:36:56 PST
Comment on attachment 447291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447291&action=review > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:118 > +#if PLATFORM(COCOA) > + platformWheelEvent = scrollingTree->wheelEventAfterFiltering(platformWheelEvent); > +#endif Can we have all platforms implement wheelEventAfterFiltering() (or the base class) as the identity function if they don't need to do any filtering to remove this #ifdef?
Radar WebKit Bug Importer
Comment 3 2021-12-22 15:30:18 PST
<rdar://problem/86828138>
Note You need to log in before you can comment on or make changes to this bug.