Bug 234355

Summary: Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2021-12-15 10:59:16 PST
Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired.
Attachments
Patch (1.81 KB, patch)
2021-12-15 11:06 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2021-12-15 19:25 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-12-15 10:59:29 PST
<rdar://problem/86532703>
Andres Gonzalez
Comment 2 2021-12-15 11:06:36 PST
Created attachment 447261 [details] Patch
chris fleizach
Comment 3 2021-12-15 11:34:50 PST
Comment on attachment 447261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447261&action=review > Source/WebCore/ChangeLog:10 > + extra new line
Andres Gonzalez
Comment 4 2021-12-15 19:25:42 PST
Created attachment 447316 [details] Patch
Andres Gonzalez
Comment 5 2021-12-15 19:28:19 PST
(In reply to chris fleizach from comment #3) > Comment on attachment 447261 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447261&action=review > > > Source/WebCore/ChangeLog:10 > > + > > extra new line Fixed. Also found another instance of this problem with m_passwordNotificationsToPost.
EWS
Comment 6 2021-12-16 09:01:08 PST
Committed r287139 (245323@main): <https://commits.webkit.org/245323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447316 [details].
Darin Adler
Comment 7 2021-12-16 13:26:22 PST
Comment on attachment 447316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447316&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:1085 > auto notifications = WTFMove(m_notificationsToPost); > + m_notificationsToPost.clear(); The best idiom for this sort of thing is: auto notifications = std::exchange(m_notificationsToPost, { });
Andres Gonzalez
Comment 8 2022-01-06 06:41:27 PST
(In reply to Darin Adler from comment #7) > Comment on attachment 447316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447316&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:1085 > > auto notifications = WTFMove(m_notificationsToPost); > > + m_notificationsToPost.clear(); > > The best idiom for this sort of thing is: > > auto notifications = std::exchange(m_notificationsToPost, { }); Thanks, corrected in https://bugs.webkit.org/show_bug.cgi?id=234919.
Note You need to log in before you can comment on or make changes to this bug.