Bug 234354

Summary: More cleanup after PluginProcess removal
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237555    
Attachments:
Description Flags
Patch none

Description Alex Christensen 2021-12-15 10:40:00 PST
More cleanup after PluginProcess removal
Comment 1 Alex Christensen 2021-12-15 10:41:42 PST
Created attachment 447255 [details]
Patch
Comment 2 Tim Horton 2021-12-15 11:39:52 PST
Comment on attachment 447255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447255&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-398
> -		3CAECB6627465AE400AB78D0 /* UnifiedSource113.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3CAECB5E27465AE300AB78D0 /* UnifiedSource113.cpp */; };

Certainly not strictly necessary, why are you shrinking!

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:830
> +		3CAECB6627465AE400AB78D0 /* UnifiedSource113.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3CAECB5E27465AE300AB78D0 /* UnifiedSource113.cpp */; };

I think you need to do some sort-xcode-project-whatever
Comment 3 Alex Christensen 2021-12-15 11:42:21 PST
Comment on attachment 447255 [details]
Patch

This is what Xcode did.  It sorts that section by the "5CAECB6627465AE400AB78D0" not by the "UnifiedSource115.cpp"
Comment 4 EWS 2021-12-15 11:59:06 PST
Committed r287093 (245285@main): <https://commits.webkit.org/245285@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447255 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-15 12:00:32 PST
<rdar://problem/86535824>