Bug 23434

Summary:

Add WML <input> element support

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

XML

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

23433

Bug Blocks:

20393

Attachments:

Description	Flags
Initial patch	staikos: review+

Description Nikolas Zimmermann 2009-01-20 09:59:24 PST

Add WMLInputElement, as first step don't handle any WML specific attributes (format/emptyok/etc..) only make them work. Follow-up patches will add the necessary WML specific logic.

Comment 1 Nikolas Zimmermann 2009-01-20 13:55:45 PST

Created attachment 26871 [details]
Initial patch

Comment 2 George Staikos 2009-01-20 14:13:12 PST

Comment on attachment 26871 [details]
Initial patch

Copyright should be 2009, and those bools don't need to be bitfields right now. otherwise R+

Comment 3 Nikolas Zimmermann 2009-01-20 14:18:56 PST

(In reply to comment #2)
> (From update of attachment 26871 [details] [review])
> Copyright should be 2009, and those bools don't need to be bitfields right now.
> otherwise R+
> 
Thanks for the r+, I'll change the copyright to list 2008 & 2009.

Comment 4 Eric Seidel (no email) 2009-01-20 14:20:50 PST

Comment on attachment 26871 [details]
Initial patch

Looks sane.  r=me too.

Comment 5 Nikolas Zimmermann 2009-01-20 14:29:39 PST

Thanks Eric, you're not mentioned in the ChangeLog, as I commited before I saw your message.
Landed in r40071.