Bug 234339

Summary: Make use of PLATFORM(COCOA) in MediaRecorder WebPreference
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=231085
Attachments:
Description Flags
Patch
none
Patch for landing youennf: commit-queue+

Description youenn fablet 2021-12-15 02:04:01 PST 
Make use of HAVE(AVASSETWRITERDELEGATE_API) in MediaRecorder WebPreference
Comment 1 youenn fablet 2021-12-15 02:15:33 PST 
<rdar://85432071>
Comment 2 youenn fablet 2021-12-15 02:16:08 PST 
Created attachment 447211 [details]
Patch
Comment 3 youenn fablet 2021-12-15 02:17:09 PST 
It is very easy to fall into that disable-feature trap.
It seems we should be able to catch these bugs earlier though.
Comment 4 Eric Carlson 2021-12-15 05:26:51 PST 
Comment on attachment 447211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447211&action=review

> Source/WTF/ChangeLog:11
> +        Llet's guard MediaRecorder with PLATFORM(COCOA).

s/Llet's/Let's/
Comment 5 youenn fablet 2021-12-15 05:47:39 PST 
Created attachment 447226 [details]
Patch for landing
Comment 6 EWS 2021-12-15 06:41:56 PST 
Committed r287072 (245267@main): <https://commits.webkit.org/245267@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447226 [details].
Comment 7 Eric Carlson 2021-12-15 08:24:35 PST 
Caused by r283431