Bug 234320

Summary:

Add client layer plumbing for classifying modal container controls

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Platform

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, annulen, bdakin, cdumez, dino, ews-watchlist, gyuyoung.kim, japhet, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Rebase on trunk	none
Fix ChangeLog	none
Add missing WTFMove()	none
Patch for landing	none

Wenson Hsieh

Reported 2021-12-14 15:43:20 PST

Attachments
Patch (21.78 KB, patch) 2021-12-17 12:11 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Rebase on trunk (21.91 KB, patch) 2021-12-18 11:35 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Fix ChangeLog (21.77 KB, patch) 2021-12-18 11:37 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Add missing WTFMove() (21.78 KB, patch) 2021-12-18 15:56 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch for landing (21.79 KB, patch) 2021-12-19 11:35 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2021-12-17 12:11:25 PST Comment hidden (obsolete)

Created attachment 447467 [details] Patch

Wenson Hsieh

Comment 2 2021-12-18 11:35:01 PST Comment hidden (obsolete)

Created attachment 447525 [details] Rebase on trunk

Wenson Hsieh

Comment 3 2021-12-18 11:37:42 PST Comment hidden (obsolete)

Created attachment 447526 [details] Fix ChangeLog

Wenson Hsieh

Comment 4 2021-12-18 15:56:34 PST

Created attachment 447534 [details] Add missing WTFMove()

Wenson Hsieh

Comment 5 2021-12-19 11:28:47 PST

Comment on attachment 447534 [details] Add missing WTFMove() View in context: https://bugs.webkit.org/attachment.cgi?id=447534&action=review Thanks for the review! > Source/WebCore/page/ChromeClient.h:147 > +enum class ModalContainerControlType : uint8_t; (I'll keep this sorted in alphabetical order before landing)

Wenson Hsieh

Comment 6 2021-12-19 11:35:00 PST

Created attachment 447552 [details] Patch for landing

EWS

Comment 7 2021-12-19 12:44:45 PST

Committed r287247 (245405@main): <https://commits.webkit.org/245405@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447552 [details].

Radar WebKit Bug Importer

Comment 8 2021-12-19 12:45:20 PST

<rdar://problem/86697812>

Note You need to log in before you can comment on or make changes to this bug.