Bug 234320

Summary: Add client layer plumbing for classifying modal container controls
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, annulen, bdakin, cdumez, dino, ews-watchlist, gyuyoung.kim, japhet, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebase on trunk
none
Fix ChangeLog
none
Add missing WTFMove()
none
Patch for landing none

Description Wenson Hsieh 2021-12-14 15:43:20 PST
.
Comment 1 Wenson Hsieh 2021-12-17 12:11:25 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-12-18 11:35:01 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-12-18 11:37:42 PST Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2021-12-18 15:56:34 PST
Created attachment 447534 [details]
Add missing WTFMove()
Comment 5 Wenson Hsieh 2021-12-19 11:28:47 PST
Comment on attachment 447534 [details]
Add missing WTFMove()

View in context: https://bugs.webkit.org/attachment.cgi?id=447534&action=review

Thanks for the review!

> Source/WebCore/page/ChromeClient.h:147
> +enum class ModalContainerControlType : uint8_t;

(I'll keep this sorted in alphabetical order before landing)
Comment 6 Wenson Hsieh 2021-12-19 11:35:00 PST
Created attachment 447552 [details]
Patch for landing
Comment 7 EWS 2021-12-19 12:44:45 PST
Committed r287247 (245405@main): <https://commits.webkit.org/245405@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447552 [details].
Comment 8 Radar WebKit Bug Importer 2021-12-19 12:45:20 PST
<rdar://problem/86697812>