| Summary: | [JSC] OpInstanceofCustom should be in CommonSlowPaths | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ross Kirsling
2021-12-14 14:17:50 PST
Created attachment 447161 [details]
Patch
Comment on attachment 447161 [details] Patch This change looks good since Symbol.hasInstance hasn't get much usage on the web, and it will also simplify https://bugs.webkit.org/show_bug.cgi?id=216816, which I pledge to get thoroughly benchmarked and reviewed during / right after the 🎄 break. r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the instanceof-bound.js, which takes this path). Comment on attachment 447161 [details] Patch (In reply to Alexey Shvayka from comment #2) > Comment on attachment 447161 [details] > Patch > > This change looks good since Symbol.hasInstance hasn't get much usage on the > web, and it will also simplify > https://bugs.webkit.org/show_bug.cgi?id=216816, which I pledge to get > thoroughly benchmarked and reviewed during / right after the 🎄 break. > > r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the > instanceof-bound.js, which takes this path). Thanks, sounds great! The results indeed seem neutral. Committed r287058 (245254@main): <https://commits.webkit.org/245254@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447161 [details]. |