Bug 234316

Summary: [JSC] OpInstanceofCustom should be in CommonSlowPaths
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2021-12-14 14:17:50 PST
[JSC] OpInstanceofCustom should be in CommonSlowPaths
Attachments
Patch (10.61 KB, patch)
2021-12-14 14:23 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-12-14 14:23:54 PST
Created attachment 447161 [details] Patch
Alexey Shvayka
Comment 2 2021-12-14 15:38:14 PST
Comment on attachment 447161 [details] Patch This change looks good since Symbol.hasInstance hasn't get much usage on the web, and it will also simplify https://bugs.webkit.org/show_bug.cgi?id=216816, which I pledge to get thoroughly benchmarked and reviewed during / right after the 🎄 break. r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the instanceof-bound.js, which takes this path).
Ross Kirsling
Comment 3 2021-12-14 16:41:08 PST
Comment on attachment 447161 [details] Patch (In reply to Alexey Shvayka from comment #2) > Comment on attachment 447161 [details] > Patch > > This change looks good since Symbol.hasInstance hasn't get much usage on the > web, and it will also simplify > https://bugs.webkit.org/show_bug.cgi?id=216816, which I pledge to get > thoroughly benchmarked and reviewed during / right after the 🎄 break. > > r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the > instanceof-bound.js, which takes this path). Thanks, sounds great! The results indeed seem neutral.
EWS
Comment 4 2021-12-14 17:24:56 PST
Committed r287058 (245254@main): <https://commits.webkit.org/245254@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447161 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-14 17:25:18 PST
<rdar://problem/86498327>
Note You need to log in before you can comment on or make changes to this bug.