Bug 234310

Summary: Split ATK specific code in WPEViewBackends
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WPE WebKitAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Don Olmstead
Reported 2021-12-14 13:45:27 PST
...
Attachments
WIP Patch (13.82 KB, patch)
2021-12-14 13:52 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (13.82 KB, patch)
2021-12-14 13:58 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (14.90 KB, patch)
2021-12-14 14:58 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (14.97 KB, patch)
2021-12-14 16:19 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (16.76 KB, patch)
2021-12-14 22:27 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.20 KB, patch)
2021-12-14 22:31 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-12-14 13:52:21 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2021-12-14 13:58:01 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2021-12-14 14:58:50 PST Comment hidden (obsolete)
Don Olmstead
Comment 4 2021-12-14 16:19:28 PST Comment hidden (obsolete)
Don Olmstead
Comment 5 2021-12-14 22:27:23 PST Comment hidden (obsolete)
Don Olmstead
Comment 6 2021-12-14 22:31:30 PST
Created attachment 447205 [details] Patch
Michael Catanzaro
Comment 7 2021-12-15 08:13:26 PST
Comment on attachment 447205 [details] Patch This looks fine to me, but I'll let a WPE port maintainer give the final r+. The other way to do it would be to create Tools/wpe/backends/wpe/ViewBackendWPE.cpp as the "WPE port version of the WPE ViewBackend" so that it can contain WPE port-specific stuff separate from the generic libwpe stuff, which might be more typical for us and could include more than just ATK dependencies. But maybe that's just too confusing. :)
EWS
Comment 8 2021-12-15 13:33:29 PST
Committed r287105 (245294@main): <https://commits.webkit.org/245294@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447205 [details].
Note You need to log in before you can comment on or make changes to this bug.