Bug 234310

Summary: Split ATK specific code in WPEViewBackends
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WPE WebKitAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Don Olmstead 2021-12-14 13:45:27 PST 
...
Comment 1 Don Olmstead 2021-12-14 13:52:21 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-12-14 13:58:01 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2021-12-14 14:58:50 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2021-12-14 16:19:28 PST Comment hidden (obsolete)
Comment 5 Don Olmstead 2021-12-14 22:27:23 PST Comment hidden (obsolete)
Comment 6 Don Olmstead 2021-12-14 22:31:30 PST 
Created attachment 447205 [details]
Patch
Comment 7 Michael Catanzaro 2021-12-15 08:13:26 PST 
Comment on attachment 447205 [details]
Patch

This looks fine to me, but I'll let a WPE port maintainer give the final r+.

The other way to do it would be to create Tools/wpe/backends/wpe/ViewBackendWPE.cpp as the "WPE port version of the WPE ViewBackend" so that it can contain WPE port-specific stuff separate from the generic libwpe stuff, which might be more typical for us and could include more than just ATK dependencies. But maybe that's just too confusing. :)
Comment 8 EWS 2021-12-15 13:33:29 PST 
Committed r287105 (245294@main): <https://commits.webkit.org/245294@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447205 [details].