Summary: | Frame Refactor: Move methods from Frame to Editor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Holger Freyther <zecke> | ||||
Component: | WebKit Misc. | Assignee: | Holger Freyther <zecke> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Holger Freyther
2009-01-20 03:58:53 PST
Created attachment 26862 [details]
Do the moving
Tests pass on the mac. I need to verify the result o git rebase and manual merging as I was hit hard by Sam's work on killing FramePrivate. Review and comments are appreciated right now.
Comment on attachment 26862 [details]
Do the moving
So long as you're just moving code, this looks great. I worry that this patch is long-since rotten (that the methods you're moving may have changed).
It seems a little strange that selectedText() is on Editor instead of say SelectionController, but it seems fine.
r=me, if you make sure the patch is updated to compile with TOT with all the LayoutTests passing and that you're certain that the code you are moving is up-to-date.
Comment on attachment 26862 [details]
Do the moving
Not much use having this in the commit queue. You have my r+ if this is updated to work on TOT. I guess I'll mark it r- for now and you can re-post a patch which applies on TOT.
Fixed in http://trac.webkit.org/changeset/67122. *** This bug has been marked as a duplicate of bug 45218 *** |