Bug 23426 – Frame Refactor: Move isFrameSet to Document

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Holger Freyther]

Move isFrameSet to Document as commented in Frame.h.

[Holger Freyther]

Created attachment 26856 [details]
Carry out the move

I think the added null check (if correct) looks ugly and it would be a case for leaving isFrameSet in Frame. Test cases pass on the mac.

[Darin Adler]

Comment on attachment 26856 [details]
Carry out the move

> +bool Document::isFrameSet() const
> +{
> +    if (!isHTMLDocument())
> +        return false;

This should be a virtual function, then, and be overridden in HTMLDocument. That wasn't possible before when this was a function on Frame.

I'll say r=me, but it would be better to do it that way

[Holger Freyther]

Created attachment 27209 [details]
Make isFrameSet virtual

Take Darin's comment into account and make isFrameSet virtual. Reimplement it in HTMLDocument (this patch is not tested).

[Holger Freyther]

Comment on attachment 26856 [details]
Carry out the move

Landed in r40443, leaving this bug open due the new patch.

[Sam Weinig]

Comment on attachment 27209 [details]
Make isFrameSet virtual

r=me

> +bool HTMLDocument::isFrameSet() const
> +{
> +    HTMLElement *bodyElement = body();
* should be on the other side.

[Holger Freyther]

Closing it. The style fix was included.