Summary: | [css-flexbox] Absolutely positioned children should be aligned using the margin box | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, obyknovenius, pdr, rbuis, svillar, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sergio Villar Senin
2021-12-13 08:49:21 PST
Created attachment 447009 [details]
Patch
Comment on attachment 447009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447009&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:1687 > + auto availableSpace = availableAlignmentSpaceForChild(crossAxisContentExtent(), child); availableAlignmentSpaceForChild() method contains an assertion: ASSERT(!child.isOutOfFlowPositioned()); Won't it fail in case of a positioned child? (In reply to Vitaly Dyachkov from comment #2) > Comment on attachment 447009 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447009&action=review > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:1687 > > + auto availableSpace = availableAlignmentSpaceForChild(crossAxisContentExtent(), child); > > availableAlignmentSpaceForChild() method contains an assertion: > ASSERT(!child.isOutOfFlowPositioned()); Won't it fail in case of a > positioned child? Right, that's why EWS are complaining. I'll review tomorrow why that assert was added, looks like it does not make much sense. Created attachment 447117 [details]
Patch
Is there anything I can do to speed up the review process? Committed r287064 (245259@trunk): <https://commits.webkit.org/245259@trunk> |