Bug 234241

Summary: Missing includes in SessionStorage breaks non-unified builds
Product: WebKit Reporter: Chris Lord <clord>
Component: WebKit Misc.Assignee: Chris Lord <clord>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, sihui_liu
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Chris Lord
Reported 2021-12-13 06:31:17 PST
I actually hit this in unified builds after making small, unrelated changes, but presumably it also breaks non-unified builds. SessionStorage.h is missing a couple of includes.
Attachments
Patch (1.26 KB, patch)
2021-12-13 06:34 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2021-12-13 09:14 PST, Chris Lord 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2021-12-13 06:34:28 PST
Created attachment 447000 [details] Patch
Chris Dumez
Comment 2 2021-12-13 07:22:12 PST
Comment on attachment 447000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447000&action=review > Source/WebKit/NetworkProcess/storage/SessionStorageManager.h:31 > +#include <WebCore/ClientOrigin.h> Should likely be a forward declaration.
Chris Lord
Comment 3 2021-12-13 09:14:14 PST
Created attachment 447015 [details] Patch
Chris Lord
Comment 4 2021-12-14 03:17:20 PST
This was fixed by unreviewed change https://trac.webkit.org/changeset/286946/webkit
Note You need to log in before you can comment on or make changes to this bug.