Bug 234233

Summary:

[GTK][a11y] Handle the Embedded method sent by AtkSocket from AccessibilityRootAtspi

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

230253

Attachments:

Description	Flags
Patch	aperez: review+, ews-feeder: commit-queue-
Patch for landing	none

Description Carlos Garcia Campos 2021-12-13 04:00:54 PST

I added some hacks to send the socket path to the web process using WebKit IPC because Embedded message is not in the DBus interface. We can simply add the message to the interface definition and handle it instead to simplify everything.

Comment 1 Carlos Garcia Campos 2021-12-13 04:03:44 PST

Created attachment 446986 [details]
Patch

Comment 2 Adrian Perez 2021-12-13 04:17:23 PST

Comment on attachment 446986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446986&action=review

> Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:200
> +    m_parentPath = parentPath;

Nice, and I like it that this allows to remove the USE(GTK4) switcheroo above
and the USE(ATSPI) one down below 💪️

Comment 3 Carlos Garcia Campos 2021-12-13 22:41:02 PST

Created attachment 447109 [details]
Patch for landing

Comment 4 Carlos Garcia Campos 2021-12-14 00:13:07 PST

Committed r287014 (245219@trunk): <https://commits.webkit.org/245219@trunk>