Bug 234233

Summary: [GTK][a11y] Handle the Embedded method sent by AtkSocket from AccessibilityRootAtspi
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230253    
Attachments:
Description Flags
Patch
aperez: review+, ews-feeder: commit-queue-
Patch for landing none

Carlos Garcia Campos
Reported 2021-12-13 04:00:54 PST
I added some hacks to send the socket path to the web process using WebKit IPC because Embedded message is not in the DBus interface. We can simply add the message to the interface definition and handle it instead to simplify everything.
Attachments
Patch (17.89 KB, patch)
2021-12-13 04:03 PST, Carlos Garcia Campos 		aperez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (18.65 KB, patch)
2021-12-13 22:41 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-12-13 04:03:44 PST
Created attachment 446986 [details] Patch
Adrian Perez
Comment 2 2021-12-13 04:17:23 PST
Comment on attachment 446986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446986&action=review > Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:200 > + m_parentPath = parentPath; Nice, and I like it that this allows to remove the USE(GTK4) switcheroo above and the USE(ATSPI) one down below 💪️
Carlos Garcia Campos
Comment 3 2021-12-13 22:41:02 PST
Created attachment 447109 [details] Patch for landing
Carlos Garcia Campos
Comment 4 2021-12-14 00:13:07 PST
Committed r287014 (245219@trunk): <https://commits.webkit.org/245219@trunk>
Note You need to log in before you can comment on or make changes to this bug.