Bug 234216

Summary: Hide viewport-constrained elements that are detected by ModalContainerObserver
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Layout and RenderingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234214    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
For EWS none

Wenson Hsieh
Reported 2021-12-12 14:52:58 PST
.
Attachments
Patch (4.81 KB, patch)
2021-12-12 16:32 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2021-12-12 21:48 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2021-12-16 13:09 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (3.57 KB, patch)
2021-12-17 16:55 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-12-12 16:32:16 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-12-12 21:48:06 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2021-12-16 13:09:25 PST
Created attachment 447388 [details] Patch
Tim Horton
Comment 4 2021-12-17 14:55:22 PST
Comment on attachment 447388 [details] Patch This seems to address Antti's concerns (though would be good to get his input, maybe asynchronously). Maybe move your check up beyond the unconditional quirks one?
Wenson Hsieh
Comment 5 2021-12-17 16:37:04 PST
Thanks for taking a look! (In reply to Tim Horton from comment #4) > Comment on attachment 447388 [details] > Patch > > This seems to address Antti's concerns (though would be good to get his > input, maybe asynchronously). Maybe move your check up beyond the > unconditional quirks one? 👍🏻
Wenson Hsieh
Comment 6 2021-12-17 16:55:16 PST
Created attachment 447496 [details] For EWS
EWS
Comment 7 2021-12-17 21:46:54 PST
Committed r287219 (245382@main): <https://commits.webkit.org/245382@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447496 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-17 21:47:20 PST
<rdar://problem/86661831>
Note You need to log in before you can comment on or make changes to this bug.