Bug 234195

Summary:

[LFC][IFC] Add partial unicode-bidi support on the block container

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

zalan

Reported 2021-12-11 05:26:11 PST

ssia

Attachments
Patch (11.24 KB, patch) 2021-12-11 05:33 PST, zalan	no flags	Details Formatted Diff Diff
Patch (11.23 KB, patch) 2021-12-11 06:03 PST, zalan	no flags	Details Formatted Diff Diff
Patch (12.19 KB, patch) 2021-12-11 14:59 PST, zalan	no flags	Details Formatted Diff Diff
Patch (54.64 KB, patch) 2021-12-11 16:59 PST, zalan	no flags	Details Formatted Diff Diff
Patch (54.60 KB, patch) 2021-12-11 20:00 PST, zalan	no flags	Details Formatted Diff Diff
Patch (11.23 KB, patch) 2021-12-12 14:36 PST, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2021-12-11 05:33:17 PST

Created attachment 446876 [details] Patch

Antti Koivisto

Comment 2 2021-12-11 05:54:21 PST

Comment on attachment 446876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446876&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173 > +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi) handline?

zalan

Comment 3 2021-12-11 05:56:06 PST

(In reply to Antti Koivisto from comment #2) > Comment on attachment 446876 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=446876&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173 > > +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi) > > handline? yeah, totally spec language. :shrugs:

zalan

Comment 4 2021-12-11 06:03:42 PST

Created attachment 446878 [details] Patch

zalan

Comment 5 2021-12-11 14:59:28 PST

Created attachment 446905 [details] Patch

zalan

Comment 6 2021-12-11 16:59:08 PST

Created attachment 446914 [details] Patch

zalan

Comment 7 2021-12-11 20:00:57 PST

Created attachment 446919 [details] Patch