Bug 234195

Summary: [LFC][IFC] Add partial unicode-bidi support on the block container
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2021-12-11 05:26:11 PST 
ssia
Comment 1 zalan 2021-12-11 05:33:17 PST 
Created attachment 446876 [details]
Patch
Comment 2 Antti Koivisto 2021-12-11 05:54:21 PST 
Comment on attachment 446876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446876&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173
> +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi)

handline?
Comment 3 zalan 2021-12-11 05:56:06 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 446876 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446876&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:173
> > +static inline void handlineEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi)
> 
> handline?
yeah, totally spec language. :shrugs:
Comment 4 zalan 2021-12-11 06:03:42 PST 
Created attachment 446878 [details]
Patch
Comment 5 zalan 2021-12-11 14:59:28 PST 
Created attachment 446905 [details]
Patch
Comment 6 zalan 2021-12-11 16:59:08 PST 
Created attachment 446914 [details]
Patch
Comment 7 zalan 2021-12-11 20:00:57 PST 
Created attachment 446919 [details]
Patch
Comment 8 zalan 2021-12-12 14:36:11 PST 
Created attachment 446943 [details]
Patch
Comment 9 EWS 2021-12-12 15:50:57 PST 
Committed r286929 (245155@main): <https://commits.webkit.org/245155@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446943 [details].
Comment 10 Radar WebKit Bug Importer 2021-12-12 15:51:19 PST 
<rdar://problem/86389123>