Bug 234174

Summary: Expose a frameRate property to Web Animations
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234161    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch dino: review+, ews-feeder: commit-queue-

Antoine Quint
Reported 2021-12-10 14:01:20 PST
Expose a frameRate property to Web Animations
Attachments
Patch (16.73 KB, patch)
2021-12-10 14:22 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (21.69 KB, patch)
2021-12-11 08:02 PST, Antoine Quint 		dino: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-12-10 14:01:56 PST
<rdar://problem/86338983>
Antoine Quint
Comment 2 2021-12-10 14:22:00 PST
Created attachment 446813 [details] Patch
Antoine Quint
Comment 3 2021-12-11 08:02:51 PST
Created attachment 446885 [details] Patch
Dean Jackson
Comment 4 2021-12-11 08:14:11 PST
Comment on attachment 446885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446885&action=review > LayoutTests/webanimations/frame-rate/animation-frame-rate.html:17 > + for (let value of ["low", "high", "highest", "auto"]) { forEach would look nicer here, but that's just me :) > LayoutTests/webanimations/frame-rate/animation-frame-rate.html:29 > + for (let value of ["default", "120", null, undefined, [], {}]) { Nice. Took me a moment to work out the "120" case.
Antoine Quint
Comment 5 2021-12-11 10:20:25 PST
Committed r286915 (245141@trunk): <https://commits.webkit.org/245141@trunk>
Antoine Quint
Comment 6 2021-12-11 10:35:45 PST
I expect the Windows failure is just an issue with the new IDL file not being correctly picked up and that a clean build would succeed in passing the test testing this new interface.
Note You need to log in before you can comment on or make changes to this bug.