Bug 234174 - Expose a frameRate property to Web Animations
Summary: Expose a frameRate property to Web Animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 234161
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-10 14:01 PST by Antoine Quint
Modified: 2021-12-11 10:35 PST (History)
12 users (show)

See Also:

Attachments
Patch (16.73 KB, patch)
2021-12-10 14:22 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (21.69 KB, patch)
2021-12-11 08:02 PST, Antoine Quint 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-12-10 14:01:20 PST 
Expose a frameRate property to Web Animations
Comment 1 Radar WebKit Bug Importer 2021-12-10 14:01:56 PST 
<rdar://problem/86338983>
Comment 2 Antoine Quint 2021-12-10 14:22:00 PST 
Created attachment 446813 [details]
Patch
Comment 3 Antoine Quint 2021-12-11 08:02:51 PST 
Created attachment 446885 [details]
Patch
Comment 4 Dean Jackson 2021-12-11 08:14:11 PST 
Comment on attachment 446885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446885&action=review

> LayoutTests/webanimations/frame-rate/animation-frame-rate.html:17
> +    for (let value of ["low", "high", "highest", "auto"]) {

forEach would look nicer here, but that's just me :)

> LayoutTests/webanimations/frame-rate/animation-frame-rate.html:29
> +    for (let value of ["default", "120", null, undefined, [], {}]) {

Nice. Took me a moment to work out the "120" case.
Comment 5 Antoine Quint 2021-12-11 10:20:25 PST 
Committed r286915 (245141@trunk): <https://commits.webkit.org/245141@trunk>
Comment 6 Antoine Quint 2021-12-11 10:35:45 PST 
I expect the Windows failure is just an issue with the new IDL file not being correctly picked up and that a clean build would succeed in passing the test testing this new interface.