Bug 234132

Summary: [WPE] Unable to launch Cog browser with run-minibrowser
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED MOVED    
Severity: Normal CC: aperez, bugs-noreply, ews-watchlist, glenn, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/Igalia/cog/pull/376
https://github.com/Igalia/cog/pull/383
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2021-12-10 01:50:53 PST
Its path changed....
Attachments
Patch (1.79 KB, patch)
2021-12-10 01:53 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2021-12-10 02:11 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-12-10 01:53:06 PST
Created attachment 446687 [details] Patch
Philippe Normand
Comment 2 2021-12-10 02:11:57 PST
Created attachment 446690 [details] Patch
Adrian Perez
Comment 3 2021-12-10 06:28:21 PST
The binary moved as a result of merging https://github.com/Igalia/cog/pull/376 I think it will be nicer to change the CMakeLists.txt in Cog to make it place the compiled binaries inside the top build directory instead of in the “launcher/” subdirectory — when developing I would rather run ”./build/cog …” to tests things rather than “./build/launcher/cog …“ OTOH, I think it is valuable to add the unit test anyway, so it's easier to catch the problem if the binaries get accidentally moved again :)
Adrian Perez
Comment 4 2021-12-10 06:37:24 PST
Location set to the old one in https://github.com/Igalia/cog/pull/383 :)
Note You need to log in before you can comment on or make changes to this bug.