| Summary: | [WPE] Unable to launch Cog browser with run-minibrowser | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED MOVED | ||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, ews-watchlist, glenn, jbedard | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://github.com/Igalia/cog/pull/376 https://github.com/Igalia/cog/pull/383 |
||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2021-12-10 01:50:53 PST
Created attachment 446687 [details]
Patch
Created attachment 446690 [details]
Patch
The binary moved as a result of merging https://github.com/Igalia/cog/pull/376 I think it will be nicer to change the CMakeLists.txt in Cog to make it place the compiled binaries inside the top build directory instead of in the “launcher/” subdirectory — when developing I would rather run ”./build/cog …” to tests things rather than “./build/launcher/cog …“ OTOH, I think it is valuable to add the unit test anyway, so it's easier to catch the problem if the binaries get accidentally moved again :) Location set to the old one in https://github.com/Igalia/cog/pull/383 :) |