| Summary: | [Playstation] Fix build break after r286751 with INTELLIGENT_TRACKING_PREVENTION enabled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jigen Zhou <jigen.zhou> | ||||||
| Component: | WebKit Misc. | Assignee: | Jigen Zhou <jigen.zhou> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, don.olmstead, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 446585 [details]
Patch
Comment on attachment 446585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446585&action=review > Source/WebKit/NetworkProcess/NetworkSession.h:44 > +#include <WebCore/ResourceError.h> Can you confirm that a forward declaration wouldn't resolve the issue? Ideally we only include what we absolutely need to in the header file. Created attachment 446593 [details]
Patch
Yes, a forward declaration works. Thanks.
Committed r286830 (245063@main): <https://commits.webkit.org/245063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446593 [details]. |
In file included from WebKit/DerivedSources/unified-sources/UnifiedSource-72468c22-4.cpp:1: In file included from C:/work/webkit/jenkins/neko/Source/WebKit\NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:32: C:/work/webkit/jenkins/neko/Source/WebKit/NetworkProcess\NetworkSession.h:197:174: error: no type named 'ResourceError' in namespace 'WebCore' virtual void requestResource(WebPageProxyIdentifier, WebCore::ResourceRequest&&, CompletionHandler<void(const IPC::DataReference&, WebCore::ResourceResponse&&, WebCore::ResourceError&&)>&&) { } ~~~~~~~~~^ 1 error generated.