| Summary: | Markup Pane not displaying. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, esprehn+autocc, ews-watchlist, hi, kangil.han, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Megan Gardner
2021-12-09 10:33:30 PST
Created attachment 446573 [details]
Patch
Comment on attachment 446573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446573&action=review > Source/WebCore/ChangeLog:3 > + Get Markup Pane to display and in the proper location. Title should describe the problem, not the fix > Source/WebKit/Shared/ContextMenuContextData.cpp:74 > + , m_controlledImageFrame(imageRect) I know I said frame, but maybe go with "bounds"? > Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:243 > + auto webView = m_webView.get(); What is this about? you can just m_webView in all the places below. Created attachment 446592 [details]
Patch
Created attachment 446603 [details]
Patch for landing
Created attachment 446604 [details]
Patch for landing
Committed r286812 (245048@main): <https://commits.webkit.org/245048@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446604 [details]. |