Bug 234089

Summary: Markup Pane not displaying.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, hi, kangil.han, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Megan Gardner
Reported 2021-12-09 10:33:30 PST
Get Markup Pane to display and in the proper location.
Attachments
Patch (14.39 KB, patch)
2021-12-09 11:15 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (14.31 KB, patch)
2021-12-09 12:54 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.30 KB, patch)
2021-12-09 14:05 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.30 KB, patch)
2021-12-09 14:09 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-12-09 11:15:45 PST
Created attachment 446573 [details] Patch
Tim Horton
Comment 2 2021-12-09 11:22:13 PST
Comment on attachment 446573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446573&action=review > Source/WebCore/ChangeLog:3 > + Get Markup Pane to display and in the proper location. Title should describe the problem, not the fix > Source/WebKit/Shared/ContextMenuContextData.cpp:74 > + , m_controlledImageFrame(imageRect) I know I said frame, but maybe go with "bounds"? > Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:243 > + auto webView = m_webView.get(); What is this about? you can just m_webView in all the places below.
Megan Gardner
Comment 3 2021-12-09 12:54:43 PST
Created attachment 446592 [details] Patch
Megan Gardner
Comment 4 2021-12-09 14:05:43 PST
Created attachment 446603 [details] Patch for landing
Megan Gardner
Comment 5 2021-12-09 14:09:28 PST
Created attachment 446604 [details] Patch for landing
EWS
Comment 6 2021-12-09 15:27:05 PST
Committed r286812 (245048@main): <https://commits.webkit.org/245048@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446604 [details].
Radar WebKit Bug Importer
Comment 7 2021-12-09 15:28:23 PST
<rdar://problem/86294041>
Note You need to log in before you can comment on or make changes to this bug.