Bug 234085

Summary: AX: Improve ASSERT while processing tree appends in AXIsolatedTree::applyPendingChanges
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2021-12-09 08:30:43 PST
The current assert: ASSERT_UNUSED(addResult, addResult.iterator->value->refCount() == 2 || (addResult.iterator->value.ptr() == m_rootNode.get() && m_rootNode->refCount() == 3)); Doesn't say what the refcount actually is, making it harder to debug. This was a problem for me when working on a previous patch.
Attachments
Patch (2.56 KB, patch)
2021-12-09 08:34 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tyler Wilcock
Comment 1 2021-12-09 08:34:10 PST
Created attachment 446552 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-12-09 13:12:43 PST
<rdar://problem/86287382>
EWS
Comment 3 2021-12-09 15:21:54 PST
Committed r286811 (245047@main): <https://commits.webkit.org/245047@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446552 [details].
Note You need to log in before you can comment on or make changes to this bug.