| Summary: | [CSS Cascade Layers] revert-layer should revert style attribute to regular author style | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 220779 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Antti Koivisto
2021-12-09 06:46:52 PST
Created attachment 446544 [details]
Patch
Created attachment 446545 [details]
Patch
Created attachment 446981 [details]
Patch
*** Bug 233937 has been marked as a duplicate of this bug. *** Comment on attachment 446981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446981&action=review > Source/WebCore/style/StyleBuilder.cpp:392 > +const PropertyCascade* Builder::ensureRollbackCascadeForRevertLayer() Mixing the terms "rollback" and "revert" make my head hurt. Can this just be "ensureRevertCascade"? And use "revert" instead of "rollback" for the rest of the patch? > Mixing the terms "rollback" and "revert" make my head hurt. Can this just be
> "ensureRevertCascade"? And use "revert" instead of "rollback" for the rest
> of the patch?
The spec calls the operation performed by revert keywords "rolling back" as in
"If the cascaded value of a property is the revert-layer keyword, the cascaded value is rolled back to the layer below"
This is trying to keep with the spec terms.
Tools/Scripts/svn-apply failed to apply attachment 446981 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 447116 [details]
Patch for landing
Committed r287018 (245223@main): <https://commits.webkit.org/245223@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447116 [details]. |