Bug 234082

Summary: [CSS Cascade Layers] revert-layer should revert style attribute to regular author style
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220779    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Antti Koivisto
Reported 2021-12-09 06:46:52 PST
It currently reverts to the next origin.
Attachments
Patch (9.52 KB, patch)
2021-12-09 06:52 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (9.48 KB, patch)
2021-12-09 06:54 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (16.24 KB, patch)
2021-12-13 02:10 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.25 KB, patch)
2021-12-14 01:29 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-12-09 06:52:17 PST
Created attachment 446544 [details] Patch
Antti Koivisto
Comment 2 2021-12-09 06:54:36 PST
Created attachment 446545 [details] Patch
Antti Koivisto
Comment 3 2021-12-13 02:10:34 PST
Created attachment 446981 [details] Patch
Antti Koivisto
Comment 4 2021-12-13 05:09:23 PST
*** Bug 233937 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 5 2021-12-13 08:26:00 PST
Comment on attachment 446981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446981&action=review > Source/WebCore/style/StyleBuilder.cpp:392 > +const PropertyCascade* Builder::ensureRollbackCascadeForRevertLayer() Mixing the terms "rollback" and "revert" make my head hurt. Can this just be "ensureRevertCascade"? And use "revert" instead of "rollback" for the rest of the patch?
Antti Koivisto
Comment 6 2021-12-13 09:42:58 PST
> Mixing the terms "rollback" and "revert" make my head hurt. Can this just be > "ensureRevertCascade"? And use "revert" instead of "rollback" for the rest > of the patch? The spec calls the operation performed by revert keywords "rolling back" as in "If the cascaded value of a property is the revert-layer keyword, the cascaded value is rolled back to the layer below" This is trying to keep with the spec terms.
EWS
Comment 7 2021-12-13 12:29:27 PST
Tools/Scripts/svn-apply failed to apply attachment 446981 [details] to trunk. Please resolve the conflicts and upload a new patch.
Antti Koivisto
Comment 8 2021-12-14 01:29:15 PST
Created attachment 447116 [details] Patch for landing
EWS
Comment 9 2021-12-14 02:15:03 PST
Committed r287018 (245223@main): <https://commits.webkit.org/245223@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447116 [details].
Radar WebKit Bug Importer
Comment 10 2021-12-14 02:16:20 PST
<rdar://problem/86458381>
Note You need to log in before you can comment on or make changes to this bug.