Bug 234076

Summary:

Web Inspector: test webpage keeps reloading when Inspector is open

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, inspector-bugzilla-changes, jcraig, jdiggs, pangle, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Anne van Kesteren 2021-12-09 04:51:17 PST

Trying to debug a couple things on https://bug1653882.bmoattachments.org/attachment.cgi?id=9254233 using Release 136 (Safari 15.4, WebKit 16613.1.9.2) I keep getting "This webpage was reloaded because a problem occurred."

It reproduces quite quickly when opening the Inspector for me. If not, you could also try mutating one of the nodes or running `onclick = console.log` in the Console. That usually did it for me.

Comment 1 Radar WebKit Bug Importer 2021-12-09 13:15:11 PST

<rdar://problem/86287498>

Comment 2 Alexey Proskuryakov 2021-12-10 09:46:44 PST

Infinite recursion in accessibility code. Reproduces for me after switching to Elements pane.

Comment 3 Tyler Wilcock 2021-12-12 15:37:37 PST

Created attachment 446945 [details]
Patch

Comment 4 Tyler Wilcock 2021-12-12 15:41:59 PST

Created attachment 446946 [details]
Patch

Comment 5 Tyler Wilcock 2021-12-12 15:56:55 PST

Created attachment 446947 [details]
Patch

Comment 6 chris fleizach 2021-12-12 21:51:49 PST

Comment on attachment 446947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446947&action=review

> LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html:-15
> -    <div id="title-group" role="group" title="Oranges">

Is this a case we can still
Cover? It seems like one of the reasons we made that original patch

Comment 7 Tyler Wilcock 2021-12-13 07:29:00 PST

(In reply to chris fleizach from comment #6)
> Comment on attachment 446947 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446947&action=review
> 
> > LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html:-15
> > -    <div id="title-group" role="group" title="Oranges">
> 
> Is this a case we can still
> Cover? It seems like one of the reasons we made that original patch
Yeah, looks like we use the title attribute in AccessibilityNodeObject::helpText which doesn't call accessibilityIsIgnored directly or indirectly. So I can add that back in.

Comment 8 Tyler Wilcock 2021-12-13 12:01:55 PST

Created attachment 447042 [details]
Patch

Comment 9 chris fleizach 2021-12-13 14:11:58 PST

Comment on attachment 447042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447042&action=review

> LayoutTests/ChangeLog:16
> +        shouldIgnoreGroup returns `true` if the group has one static text

probably not necessary to include the entire justification again. you already have this in WebCore

Comment 10 Tyler Wilcock 2021-12-13 14:23:26 PST

Created attachment 447065 [details]
Patch

Comment 11 Tyler Wilcock 2021-12-13 14:38:13 PST

Created attachment 447069 [details]
Patch

Comment 12 EWS 2021-12-14 12:00:37 PST

Committed r287038 (245237@main): <https://commits.webkit.org/245237@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447069 [details].