Bug 234012

Summary: Web Inspector: After r286657, anonymous layers are providing an empty string for their grouping text
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 231340    
Bug Blocks:    
Attachments:
Description Flags
Patch v1.0
none
Patch v1.1 none

Description Patrick Angle 2021-12-08 09:02:50 PST 
The frontend makes the assumption that text will only be provided for named layers, and that anonymous layers will instead forgo setting the `text` for the grouping payload. We either need to conditionalize setting the text, or handle empty strings in the frontend, not just undefined strings.
Comment 1 Radar WebKit Bug Importer 2021-12-08 09:03:08 PST 
<rdar://problem/86214025>
Comment 2 Patrick Angle 2021-12-08 15:32:53 PST 
Created attachment 446439 [details]
Patch v1.0
Comment 3 Patrick Angle 2021-12-14 12:43:19 PST 
Created attachment 447148 [details]
Patch v1.1
Comment 4 Devin Rousso 2021-12-14 12:51:52 PST 
Comment on attachment 447148 [details]
Patch v1.1

rs=me
Comment 5 EWS 2021-12-14 14:06:08 PST 
Committed r287046 (245243@main): <https://commits.webkit.org/245243@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447148 [details].