Bug 233994

Summary: GraphicsContextGLANGLE delivers context lost twice when reshape fails
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: ASSIGNED ---    
Severity: Normal CC: cmarcelo, dino, ews-watchlist, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for EWS ews-feeder: commit-queue-

Description Kimmo Kinnunen 2021-12-08 01:43:22 PST 
GraphicsContextGLANGLE delivers context lost twice when reshape fails
Comment 1 Kimmo Kinnunen 2021-12-08 01:51:07 PST 
Created attachment 446334 [details]
Patch
Comment 2 Antti Koivisto 2021-12-08 01:56:14 PST 
Comment on attachment 446334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446334&action=review

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:387
> +    // Returns true on success.
>      bool reshapeFBOs(const IntSize&);

enum class return type would requires less explanations

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:400
> -    // Returns false if context should be lost due to timeout.
> +    // Returns true on success. Returns false if context should be lost due to timeout.
>      bool waitAndUpdateOldestFrame() WARN_UNUSED_RETURN;

here too
Comment 3 Kimmo Kinnunen 2021-12-08 02:09:02 PST 
Created attachment 446337 [details]
Patch for landing
Comment 4 Kimmo Kinnunen 2021-12-08 03:17:37 PST 
Created attachment 446345 [details]
Patch for landing
Comment 5 Kimmo Kinnunen 2021-12-08 12:16:45 PST 
Created attachment 446408 [details]
Patch for EWS
Comment 6 Radar WebKit Bug Importer 2021-12-15 01:44:18 PST 
<rdar://problem/86512404>