Bug 233984

Summary:

Make FontCache allowlist thread safe

Product:

WebKit

Reporter:

Cameron McCormack (:heycam) <heycam>

Component:

Layout and Rendering

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, mattwoodrow, mmaxfield, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

233488

Attachments:

Description	Flags
Patch	mmaxfield: review+, ews-feeder: commit-queue-
Patch	none

Description Cameron McCormack (:heycam) 2021-12-07 23:00:55 PST

Make FontCache allowlist thread safe

Comment 1 Cameron McCormack (:heycam) 2021-12-07 23:01:55 PST

Created attachment 446310 [details]
Patch

Comment 2 Myles C. Maxfield 2021-12-10 14:49:11 PST

Comment on attachment 446310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446310&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1225
> +    Locker locker { Allowlist::lock };

This might be an opportunity for performance improvement, since this allowlist is only used for testing.

Comment 3 Radar WebKit Bug Importer 2021-12-14 23:01:24 PST

<rdar://problem/86507543>

Comment 4 Matt Woodrow 2022-07-19 22:12:45 PDT

Created attachment 461035 [details]
Patch

Comment 5 EWS 2022-07-20 14:22:02 PDT

Committed 252657@main (af751da03e16): <https://commits.webkit.org/252657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461035 [details].