Bug 23394

Summary: Remove calls to WebCore::setDeferringTimers()
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Proposed patch alp: review+

Dmitry Titov
Reported 2009-01-16 15:16:01 PST
ResourceHandleManager for curl disables global timers during select() call to avoid being interrupted by a process signal. It appears that original effort to fix the interruption ended up using also a loop in case 'select' returns with EINTR. Loop is the sufficient way to deal with interruptions (for example, see here: http://www.wlug.org.nz/EINTR). See bug 16071 for more info. I'm removing setDeferringTimers() because nothing else uses it and I'm in the process of making TimerBase thread-aware for workers.
Attachments
Proposed patch (1.70 KB, patch)
2009-01-16 15:18 PST, Dmitry Titov 		alp: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-01-16 15:18:57 PST
Created attachment 26811 [details] Proposed patch
Alp Toker
Comment 2 2009-01-16 15:22:52 PST
Comment on attachment 26811 [details] Proposed patch r=me
Alp Toker
Comment 3 2009-01-16 15:27:15 PST
Landed in r39991, thanks for the cleanup. Please remember to follow up soon with a bug/patch that removes the unused code.
Note You need to log in before you can comment on or make changes to this bug.