Summary: | Some pixel test output includes DumpRenderTree warnings about changing main display profile | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | Pierre-Olivier Latour <pol> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz | ||||
Priority: | P2 | Keywords: | LayoutTestFailure, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
URL: | http://build.webkit.org/results/trunk-mac-intel-pixel/1433/ | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2009-01-16 14:55:37 PST
One solution would be to prefix all DumpRenderTree output with a unique string (like "DRT: ") so that run-webkit-tests knows that it should print those lines out to the console (instead of including them as part of the test output). Why don't we just remove this warning? I left it in place when I re-implement the pixel test path of DRT, but never though it had any added value. (In reply to comment #1) > One solution would be to prefix all DumpRenderTree output with a unique string > (like "DRT: ") so that run-webkit-tests knows that it should print those lines > out to the console (instead of including them as part of the test output). I think a simpler solution would be for the script, instead of DRT, to output this message. But I am fine with removing it altogether. (In reply to comment #3) > I think a simpler solution would be for the script, instead of DRT, to output > this message. But I am fine with removing it altogether. Ditto. Created attachment 26875 [details]
Patch v1
Comment on attachment 26875 [details]
Patch v1
Seems OK, r=me
Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/mac/PixelDumpSupportMac.mm Sending WebKitTools/Scripts/run-webkit-tests Transmitting file data ... Committed revision 40075. |