Bug 233903

Summary: Add web push message decryption routines
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, beidson, ews-watchlist, gyuyoung.kim, nham, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Add unit tests that were left out of original patch for landing none

Description Ben Nham 2021-12-06 16:56:26 PST 
Add web push message decryption routines
Comment 1 Ben Nham 2021-12-06 16:58:23 PST 
Created attachment 446100 [details]
Patch
Comment 2 Ben Nham 2021-12-06 17:05:18 PST 
Created attachment 446102 [details]
Patch
Comment 3 Ben Nham 2021-12-06 17:16:12 PST 
Created attachment 446105 [details]
Patch
Comment 4 Ben Nham 2021-12-06 19:40:19 PST 
Created attachment 446113 [details]
Patch
Comment 5 Ben Nham 2021-12-06 20:41:04 PST 
Created attachment 446117 [details]
Patch
Comment 6 Ben Nham 2021-12-06 22:11:57 PST 
Created attachment 446121 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2021-12-07 08:40:48 PST 
<rdar://problem/86158111>
Comment 8 Brady Eidson 2021-12-13 16:38:09 PST 
Comment on attachment 446121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446121&action=review

> Source/WebCore/Modules/push-api/PushCrypto.cpp:35
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/PushCrypto.h:36
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:37
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/PushMessageCrypto.h:37
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {

> Source/WebCore/Modules/push-api/cocoa/PushCryptoCocoa.cpp:37
> +namespace WebCore {
> +
> +namespace PushCrypto {

namespace WebCore::PushCrypto {
Comment 9 Ben Nham 2021-12-13 23:14:06 PST 
Created attachment 447110 [details]
Patch
Comment 10 Ben Nham 2021-12-13 23:19:45 PST 
Created attachment 447111 [details]
Patch
Comment 11 EWS 2021-12-14 00:19:11 PST 
Committed r287015 (245220@main): <https://commits.webkit.org/245220@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447111 [details].
Comment 12 Ben Nham 2022-01-29 11:53:17 PST 
Reopening to attach new patch.
Comment 13 Ben Nham 2022-01-29 11:53:19 PST 
Created attachment 450329 [details]
Add unit tests that were left out of original patch for landing
Comment 14 EWS 2022-01-29 21:22:42 PST 
Committed r288796 (246573@main): <https://commits.webkit.org/246573@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450329 [details].