Bug 233903

Summary: Add web push message decryption routines
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, beidson, ews-watchlist, gyuyoung.kim, nham, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Add unit tests that were left out of original patch for landing none

Ben Nham
Reported 2021-12-06 16:56:26 PST
Add web push message decryption routines
Attachments
Patch (45.98 KB, patch)
2021-12-06 16:58 PST, Ben Nham 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (46.20 KB, patch)
2021-12-06 17:05 PST, Ben Nham 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (46.24 KB, patch)
2021-12-06 17:16 PST, Ben Nham 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (46.13 KB, patch)
2021-12-06 19:40 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (46.16 KB, patch)
2021-12-06 20:41 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (51.10 KB, patch)
2021-12-06 22:11 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (51.18 KB, patch)
2021-12-13 23:14 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (39.17 KB, patch)
2021-12-13 23:19 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Add unit tests that were left out of original patch for landing (12.01 KB, patch)
2022-01-29 11:53 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2021-12-06 16:58:23 PST
Created attachment 446100 [details] Patch
Ben Nham
Comment 2 2021-12-06 17:05:18 PST
Created attachment 446102 [details] Patch
Ben Nham
Comment 3 2021-12-06 17:16:12 PST
Created attachment 446105 [details] Patch
Ben Nham
Comment 4 2021-12-06 19:40:19 PST
Created attachment 446113 [details] Patch
Ben Nham
Comment 5 2021-12-06 20:41:04 PST
Created attachment 446117 [details] Patch
Ben Nham
Comment 6 2021-12-06 22:11:57 PST
Created attachment 446121 [details] Patch
Radar WebKit Bug Importer
Comment 7 2021-12-07 08:40:48 PST
<rdar://problem/86158111>
Brady Eidson
Comment 8 2021-12-13 16:38:09 PST
Comment on attachment 446121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446121&action=review > Source/WebCore/Modules/push-api/PushCrypto.cpp:35 > +namespace WebCore { > + > +namespace PushCrypto { namespace WebCore::PushCrypto { > Source/WebCore/Modules/push-api/PushCrypto.h:36 > +namespace WebCore { > + > +namespace PushCrypto { namespace WebCore::PushCrypto { > Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:37 > +namespace WebCore { > + > +namespace PushCrypto { namespace WebCore::PushCrypto { > Source/WebCore/Modules/push-api/PushMessageCrypto.h:37 > +namespace WebCore { > + > +namespace PushCrypto { namespace WebCore::PushCrypto { > Source/WebCore/Modules/push-api/cocoa/PushCryptoCocoa.cpp:37 > +namespace WebCore { > + > +namespace PushCrypto { namespace WebCore::PushCrypto {
Ben Nham
Comment 9 2021-12-13 23:14:06 PST
Created attachment 447110 [details] Patch
Ben Nham
Comment 10 2021-12-13 23:19:45 PST
Created attachment 447111 [details] Patch
EWS
Comment 11 2021-12-14 00:19:11 PST
Committed r287015 (245220@main): <https://commits.webkit.org/245220@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447111 [details].
Ben Nham
Comment 12 2022-01-29 11:53:17 PST
Reopening to attach new patch.
Ben Nham
Comment 13 2022-01-29 11:53:19 PST
Created attachment 450329 [details] Add unit tests that were left out of original patch for landing
EWS
Comment 14 2022-01-29 21:22:42 PST
Committed r288796 (246573@main): <https://commits.webkit.org/246573@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450329 [details].
Note You need to log in before you can comment on or make changes to this bug.