Bug 233872

Summary:

[LBSE] Handle RenderSVGRoot in all places that handle LegacyRenderSVGRoot

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, changseok, dino, dmazzoni, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jcraig, jdiggs, kondapallykalyan, pdr, rbuis, rwlbuis, sabouhallawa, samuel_white, schenney, sergio, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

233863

Bug Blocks:

90738, 233873

Attachments:

Description	Flags
Patch, v1	none
Patch, v2	rbuis: review+

Description Nikolas Zimmermann 2021-12-06 06:04:45 PST

Now that RenderSVGRoot is available, we need to hook it into various places in WebCore, that currently handle LegacyRenderSVGRoot.

Comment 1 Nikolas Zimmermann 2021-12-10 03:28:41 PST

Created attachment 446704 [details]
Patch, v1

Comment 2 Rob Buis 2021-12-10 03:33:20 PST

Comment on attachment 446704 [details]
Patch, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=446704&action=review

> Source/WebCore/svg/SVGSVGElement.cpp:510
> +        return { 0, 0, floatValueForLength(intrinsicWidth, 0), floatValueForLength(intrinsicHeight, 0) };

Since a lot of code is duplicated, can this be shared better?

Comment 3 Nikolas Zimmermann 2021-12-10 04:01:50 PST

Created attachment 446709 [details]
Patch, v2

Comment 4 Nikolas Zimmermann 2021-12-10 04:19:58 PST

Committed r286843 (245076@trunk): <https://commits.webkit.org/245076@trunk>

Comment 5 Radar WebKit Bug Importer 2021-12-10 04:20:22 PST

<rdar://problem/86316766>