Bug 233850

Summary: [LFC][IFC] Compute isFirstBox/isLastBox for text content
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2021-12-03 19:12:39 PST 
Iterators use these bits to figure out renderer boundaries.
Comment 1 zalan 2021-12-03 19:27:37 PST 
Created attachment 445937 [details]
Patch
Comment 2 zalan 2021-12-03 21:09:56 PST 
Created attachment 445955 [details]
Patch
Comment 3 zalan 2021-12-03 22:00:21 PST 
Created attachment 445956 [details]
Patch
Comment 4 Antti Koivisto 2021-12-04 05:37:09 PST 
Comment on attachment 445956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445956&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:394
> +        enum class LineHasFirstLastRunForTextBox { No, FirstOnly, LastOnly, Both };

Don't you have a few types for this already like IsFirstLastBox and OptionSet<InlineDisplay::Box::PositionWithinInlineLevelBox>?
Comment 5 zalan 2021-12-04 06:46:43 PST 
Created attachment 445970 [details]
Patch
Comment 6 EWS 2021-12-04 08:51:46 PST 
Committed r286534 (244866@main): <https://commits.webkit.org/244866@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445970 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-04 08:52:24 PST 
<rdar://problem/86053206>