| Summary: | JSErrorHandler should not set window.event if invocation target is in shadow tree | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||
| Component: | DOM | Assignee: | Alexey Shvayka <ashvayka> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Trivial | CC: | clopez, ews-watchlist, rniwa, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://github.com/web-platform-tests/wpt/pull/31893 https://bugs.webkit.org/show_bug.cgi?id=186266 |
||||||
| Attachments: |
|
||||||
|
Description
Alexey Shvayka
2021-12-03 11:54:26 PST
Created attachment 445886 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 445886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445886&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + * web-platform-tests/dom/events/event-global-expected.txt: > + * web-platform-tests/dom/events/event-global.html: Is this merging upstream change? Or are you making a WPT change? It's unclear from the change log. (In reply to Ryosuke Niwa from comment #3) Thanks Ryosuke! > Is this merging upstream change? Or are you making a WPT change? It's > unclear from the change log. We are exporting the tests; I will make sure to note that in ChangeLog. (In reply to Alexey Shvayka from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Thanks Ryosuke! > > > Is this merging upstream change? Or are you making a WPT change? It's > > unclear from the change log. > > We are exporting the tests; I will make sure to note that in ChangeLog. Okay, in that case, please be sure to land WPT side of change first. Committed r286871 (245102@trunk): <https://commits.webkit.org/245102@trunk> |