| Summary: | Fix playstation build after r286484 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | ujwal koneru <ujwal.koneru> | ||||||||||||
| Component: | WebKit2 | Assignee: | ujwal koneru <ujwal.koneru> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | kkinnunen, ross.kirsling, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Other | ||||||||||||||
| OS: | Other | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
ujwal koneru
2021-12-03 10:17:38 PST
Created attachment 445884 [details]
[fast-cq]Patch for build fix
Remove the logging parameters that were changed in header.
Created attachment 445890 [details]
[fast-cq]Patch for build fix
Tools/Scripts/svn-apply failed to apply attachment 445890 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment on attachment 445890 [details] [fast-cq]Patch for build fix View in context: https://bugs.webkit.org/attachment.cgi?id=445890&action=review > Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp:43 > -void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters& parameters) > +void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters& ) When you reupload, you should also remove the space before the end paren here. (You could also remove the extra newline for the body if you want.) Created attachment 445899 [details]
[fast-cq]Patch for build fix
Created attachment 445901 [details]
[fast-cq]Patch for build fix
Created attachment 445907 [details] [fast-cq]Patch for build fix Added logging back in webprocess(https://trac.webkit.org/changeset/286484/webkit/trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp). For webprocess pool, parent when initialized, handles logging(https://trac.webkit.org/changeset/286484/webkit/trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp). Committed r286517 (244852@main): <https://commits.webkit.org/244852@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445907 [details]. |