Bug 233784

Summary: A Safari tab can rarely get stuck in a state where rendering updates stop happening
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
cdumez: review+, ews-feeder: commit-queue-
Patch none

Description Simon Fraser (smfr) 2021-12-02 15:06:36 PST 
A Safari tab can rarely get stuck in a state where rendering updates stop happening
Comment 1 Simon Fraser (smfr) 2021-12-02 15:13:09 PST 
Created attachment 445779 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-12-02 15:13:14 PST 
<rdar://problem/85445072>
Comment 3 Simon Fraser (smfr) 2021-12-02 15:20:04 PST 
Created attachment 445780 [details]
Patch
Comment 4 Chris Dumez 2021-12-02 15:23:29 PST 
Comment on attachment 445780 [details]
Patch

r=me
Comment 5 Chris Dumez 2021-12-02 15:37:03 PST 
Comment on attachment 445780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445780&action=review

> Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:75
>      Lock& lock() { return m_lock; }

Probably want:
Lock& lock() WTF_RETURNS_LOCK(m_lock) { return m_lock; }
Comment 6 Simon Fraser (smfr) 2021-12-02 15:52:05 PST 
Created attachment 445783 [details]
Patch
Comment 7 EWS 2021-12-02 22:05:57 PST 
Committed r286481 (244820@main): <https://commits.webkit.org/244820@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445783 [details].