Bug 233784

Summary: A Safari tab can rarely get stuck in a state where rendering updates stop happening
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
cdumez: review+, ews-feeder: commit-queue-
Patch none

Simon Fraser (smfr)
Reported 2021-12-02 15:06:36 PST
A Safari tab can rarely get stuck in a state where rendering updates stop happening
Attachments
Patch (9.19 KB, patch)
2021-12-02 15:13 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.19 KB, patch)
2021-12-02 15:20 PST, Simon Fraser (smfr) 		cdumez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.96 KB, patch)
2021-12-02 15:52 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-12-02 15:13:09 PST
Created attachment 445779 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-12-02 15:13:14 PST
<rdar://problem/85445072>
Simon Fraser (smfr)
Comment 3 2021-12-02 15:20:04 PST
Created attachment 445780 [details] Patch
Chris Dumez
Comment 4 2021-12-02 15:23:29 PST
Comment on attachment 445780 [details] Patch r=me
Chris Dumez
Comment 5 2021-12-02 15:37:03 PST
Comment on attachment 445780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445780&action=review > Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:75 > Lock& lock() { return m_lock; } Probably want: Lock& lock() WTF_RETURNS_LOCK(m_lock) { return m_lock; }
Simon Fraser (smfr)
Comment 6 2021-12-02 15:52:05 PST
Created attachment 445783 [details] Patch
EWS
Comment 7 2021-12-02 22:05:57 PST
Committed r286481 (244820@main): <https://commits.webkit.org/244820@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445783 [details].
Note You need to log in before you can comment on or make changes to this bug.