Bug 233784 - A Safari tab can rarely get stuck in a state where rendering updates stop happening
Summary: A Safari tab can rarely get stuck in a state where rendering updates stop hap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-02 15:06 PST by Simon Fraser (smfr)
Modified: 2021-12-02 22:06 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.19 KB, patch)
2021-12-02 15:13 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.19 KB, patch)
2021-12-02 15:20 PST, Simon Fraser (smfr) 		cdumez: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.96 KB, patch)
2021-12-02 15:52 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-12-02 15:06:36 PST 
A Safari tab can rarely get stuck in a state where rendering updates stop happening
Comment 1 Simon Fraser (smfr) 2021-12-02 15:13:09 PST 
Created attachment 445779 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-12-02 15:13:14 PST 
<rdar://problem/85445072>
Comment 3 Simon Fraser (smfr) 2021-12-02 15:20:04 PST 
Created attachment 445780 [details]
Patch
Comment 4 Chris Dumez 2021-12-02 15:23:29 PST 
Comment on attachment 445780 [details]
Patch

r=me
Comment 5 Chris Dumez 2021-12-02 15:37:03 PST 
Comment on attachment 445780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445780&action=review

> Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:75
>      Lock& lock() { return m_lock; }

Probably want:
Lock& lock() WTF_RETURNS_LOCK(m_lock) { return m_lock; }
Comment 6 Simon Fraser (smfr) 2021-12-02 15:52:05 PST 
Created attachment 445783 [details]
Patch
Comment 7 EWS 2021-12-02 22:05:57 PST 
Committed r286481 (244820@main): <https://commits.webkit.org/244820@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445783 [details].