Bug 23373

Summary: Implement ThreadCondition::timedWait for Win32
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 22718    
Attachments:
Description Flags
Proposed patch
none
irc_chat.txt
none
Proposed patch, v2
none
review notes (in IRC) addressed ap: review+

Dmitry Titov
Reported 2009-01-15 19:44:15 PST
The Win32 port of Threading does not have this implemented and we need it now for MessageQueue::waitForMessageTimed. The code we have is borrowed from early version of boost/pthreads-win32. I'm bringing their later revision with timedWait. See comment in ThreadingWin.cpp file for more info and related links.
Attachments
Proposed patch (18.30 KB, patch)
2009-01-15 19:56 PST, Dmitry Titov 		no flags
DetailsFormatted DiffDiff
irc_chat.txt (1.23 KB, text/plain)
2009-01-20 16:36 PST, Dmitry Titov 		no flags
Details
Proposed patch, v2 (23.89 KB, patch)
2009-01-20 16:54 PST, Dmitry Titov 		no flags
DetailsFormatted DiffDiff
review notes (in IRC) addressed (26.74 KB, patch)
2009-01-21 12:07 PST, Dmitry Titov 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-01-15 19:56:04 PST
Created attachment 26782 [details] Proposed patch Only affects Win32 code. Built on mac and win. Run workers and storage layout tests on win (those actually use threading and don't depend on font metrics :-).
Brent Fulgham
Comment 2 2009-01-15 20:53:38 PST
The patch looks good to me. I'm going to apply it to my local tree and try it out.
Brent Fulgham
Comment 3 2009-01-15 22:10:52 PST
(In reply to comment #2) > The patch looks good to me. I'm going to apply it to my local tree and try it out. FYI -- It builds and runs find in my local Cairo-based Windows build.
Dmitry Titov
Comment 4 2009-01-20 16:36:12 PST
Created attachment 26876 [details] irc_chat.txt Additional info on license use: asking questions on webkit-dev and on IRC indicates the usage of 2 licenses in a single file is ok. It is not necessary, but nice to include the lust of pthread-win32 contributors which is referred by their license. See http://www.nabble.com/Using-LGPL-derived-source-in-one-of-the-wtf-files.-td21550637.html and attached file irc_chat.txt
Dmitry Titov
Comment 5 2009-01-20 16:54:55 PST
Created attachment 26877 [details] Proposed patch, v2 Added CONTRIBUTORS and fixed couple of style issues.
Dmitry Titov
Comment 6 2009-01-21 12:07:53 PST
Created attachment 26901 [details] review notes (in IRC) addressed - renamed CONTRIBUTORS to CONTRIBUTORS.pthreads-win32 - updated ChangeLog - removed '::' for Win32 APIs - build release on Win, no warnings. Not sure where to use ASSERT_UNUSED.
Alexey Proskuryakov
Comment 7 2009-01-21 12:16:31 PST
Comment on attachment 26901 [details] review notes (in IRC) addressed r=me Perhaps MSVC doesn't warn about unused variable, or maybe we have that warning disabled.
Alexey Proskuryakov
Comment 8 2009-01-22 00:33:11 PST
Committed revision 40122.
Note You need to log in before you can comment on or make changes to this bug.