Bug 233695

Summary: GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfiguration code
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, dino, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description Kimmo Kinnunen 2021-12-01 04:28:25 PST
GraphicsContextGLANGLE should not have Cocoa Mac specific display reconfiguration code
Comment 1 Kimmo Kinnunen 2021-12-01 04:43:10 PST
Created attachment 445557 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-12-01 05:03:29 PST
Created attachment 445560 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-12-01 05:29:04 PST
Created attachment 445563 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-12-01 05:47:15 PST
Created attachment 445566 [details]
Patch
Comment 5 Kimmo Kinnunen 2021-12-02 00:50:07 PST
Created attachment 445687 [details]
Patch
Comment 6 Kimmo Kinnunen 2021-12-02 02:32:10 PST
Created attachment 445697 [details]
Patch
Comment 7 Antti Koivisto 2021-12-02 05:09:16 PST
Comment on attachment 445697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445697&action=review

> Source/WebCore/platform/graphics/mac/DisplayConfigurationMonitor.h:53
> +    Vector<Client*> m_clients;

This could use CheckedPtr for safety (by inheriting Client from CanMakeCheckedPtr).
Comment 8 EWS 2021-12-02 06:15:38 PST
Committed r286423 (244769@main): <https://commits.webkit.org/244769@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445697 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-02 06:16:38 PST
<rdar://problem/85968513>