Bug 233693

Summary: [JSC] Fix potential build break related to StructureID.h
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233699
Attachments:
Description Flags
v1
none
v2 none

Xan Lopez
Reported 2021-12-01 03:31:43 PST
The file is now using CPURegister without declaring it. This may or may not just compile because of unified builds, but it broke at least one build: https://build.webkit.org/#/builders/133/builds/4298/steps/9/logs/stdio
Attachments
v1 (1.46 KB, patch)
2021-12-01 03:32 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
v2 (1.46 KB, patch)
2021-12-01 03:37 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2021-12-01 03:32:51 PST
Created attachment 445547 [details] v1 Add include for CPURegister.
Xan Lopez
Comment 2 2021-12-01 03:37:21 PST
Created attachment 445548 [details] v2 Now with the right include!
EWS
Comment 3 2021-12-01 04:45:48 PST
Committed r286360 (244719@main): <https://commits.webkit.org/244719@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445548 [details].
Radar WebKit Bug Importer
Comment 4 2021-12-01 04:46:25 PST
<rdar://problem/85917211>
Keith Miller
Comment 5 2021-12-01 12:52:31 PST
Whoops, thanks!
Note You need to log in before you can comment on or make changes to this bug.