Bug 233691

Summary: [WebGPU] Add default values to structs in WebCore/Modules/WebGPU
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2021-12-01 00:51:29 PST
[WebGPU] Add default values to structs in WebCore/Modules/WebGPU
Attachments
Patch (30.83 KB, patch)
2021-12-01 00:52 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-12-01 00:52:32 PST
Created attachment 445539 [details] Patch
Myles C. Maxfield
Comment 2 2021-12-01 04:24:34 PST
*** Bug 233624 has been marked as a duplicate of this bug. ***
Alex Christensen
Comment 3 2021-12-01 14:55:07 PST
Comment on attachment 445539 [details] Patch Definitely an improvement. I'm still concerned about all those raw pointers. Can they be WeakPtr instead?
Myles C. Maxfield
Comment 4 2021-12-01 16:01:22 PST
(In reply to Alex Christensen from comment #3) > Comment on attachment 445539 [details] > Patch > > Definitely an improvement. I'm still concerned about all those raw > pointers. Can they be WeakPtr instead? They're not stored though... 🤔
EWS
Comment 5 2021-12-01 16:31:08 PST
Committed r286403 (244750@main): <https://commits.webkit.org/244750@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445539 [details].
Radar WebKit Bug Importer
Comment 6 2021-12-01 16:32:28 PST
<rdar://problem/85945191>
Note You need to log in before you can comment on or make changes to this bug.