Bug 233671

Summary: REGRESSION (r283431): Fix NEAR_FIELD macro for iOS
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231085    
Bug Blocks:    
Attachments:
Description Flags
Patch none

pascoe@apple.com
Reported 2021-11-30 16:56:16 PST
In https://bugs.webkit.org/show_bug.cgi?id=231085 The near field macro got changed from #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)) to #if PLATFORM(MAC) && !PLATFORM(IOS_FAMILY_SIMULATOR). The latter disables NEAR_FIELD for all iOS devices, breaking WebAuthn with NFC.
Attachments
Patch (1.36 KB, patch)
2021-11-30 17:16 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
pascoe@apple.com
Comment 1 2021-11-30 16:56:22 PST
rdar://85318070
pascoe@apple.com
Comment 2 2021-11-30 17:16:29 PST
Created attachment 445491 [details] Patch
Brent Fulgham
Comment 3 2021-12-01 10:24:50 PST
Comment on attachment 445491 [details] Patch r=me
EWS
Comment 4 2021-12-01 11:01:42 PST
Committed r286370 (244729@main): <https://commits.webkit.org/244729@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445491 [details].
Note You need to log in before you can comment on or make changes to this bug.