Bug 233619

Summary: [WebGPU] Hook up navigator.gpu.requestAdapter()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 233600    
Bug Blocks: 233622    
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2021-11-29 21:58:56 PST
Hook up navigator.gpu.requestAdapter()
Attachments
Patch (34.25 KB, patch)
2021-11-29 22:12 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (36.20 KB, patch)
2021-11-30 13:57 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-11-29 22:12:53 PST
Created attachment 445381 [details] Patch
Myles C. Maxfield
Comment 2 2021-11-29 22:19:24 PST
*** Bug 233534 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 3 2021-11-29 23:29:31 PST
With this patch, we have enough for the first function call !!! v.excited
Myles C. Maxfield
Comment 4 2021-11-29 23:42:59 PST
Comment on attachment 445381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445381&action=review > Source/WebCore/page/WorkerNavigator.cpp:51 > + // FIXME: Implement this. https://bugs.webkit.org/show_bug.cgi?id=233622
Myles C. Maxfield
Comment 5 2021-11-30 13:57:44 PST
Created attachment 445468 [details] Patch
Dean Jackson
Comment 6 2021-12-02 14:58:34 PST
Comment on attachment 445468 [details] Patch Can we test this?
Myles C. Maxfield
Comment 7 2021-12-02 15:00:39 PST
(In reply to Dean Jackson from comment #6) > Comment on attachment 445468 [details] > Patch > > Can we test this? We can! But Apple has to get its internal build system set up first. As soon as that happens I'll add the test. Yay!!!!
EWS
Comment 8 2021-12-02 15:37:26 PST
Committed r286459 (244800@main): <https://commits.webkit.org/244800@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445468 [details].
Radar WebKit Bug Importer
Comment 9 2021-12-02 15:38:23 PST
<rdar://problem/85992595>
Note You need to log in before you can comment on or make changes to this bug.