Bug 233617

Summary: [WebXR] Implement ChromeClient API to allow getting explicit consent from user on session features
Product: WebKit Reporter: Ada Chan <adachan>
Component: New BugsAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, svillar, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
Patch for landing none

Ada Chan
Reported 2021-11-29 21:14:26 PST
[WebXR] Implement ChromeClient API to allow getting explicit consent from user on session features
Attachments
Patch (35.26 KB, patch)
2021-11-29 21:43 PST, Ada Chan 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (35.31 KB, patch)
2021-11-30 11:14 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2021-11-29 21:43:39 PST
Created attachment 445380 [details] Patch
Sergio Villar Senin
Comment 2 2021-11-30 02:11:18 PST
Comment on attachment 445380 [details] Patch The WebXR spec requires us to use the Permissions API https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned at some point that there was interest in implementing the Permissions API. Here you're using an ad-hoc solution via ChromeClient that should be replaced at some point by the permissions API variant.
Ada Chan
Comment 3 2021-11-30 08:45:15 PST
(In reply to Sergio Villar Senin from comment #2) > Comment on attachment 445380 [details] > Patch > > The WebXR spec requires us to use the Permissions API > https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned > at some point that there was interest in implementing the Permissions API. > > Here you're using an ad-hoc solution via ChromeClient that should be > replaced at some point by the permissions API variant. I'll add a FIXME about replacing that with the Permissions API.
Dean Jackson
Comment 4 2021-11-30 10:49:51 PST
(In reply to Sergio Villar Senin from comment #2) > Comment on attachment 445380 [details] > Patch > > The WebXR spec requires us to use the Permissions API > https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned > at some point that there was interest in implementing the Permissions API. > > Here you're using an ad-hoc solution via ChromeClient that should be > replaced at some point by the permissions API variant. Yeah, we'll use this until we implement Permissions.
Ada Chan
Comment 5 2021-11-30 11:14:26 PST
Created attachment 445446 [details] Patch for landing
EWS
Comment 6 2021-11-30 12:41:53 PST
Committed r286318 (244677@main): <https://commits.webkit.org/244677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445446 [details].
Radar WebKit Bug Importer
Comment 7 2021-11-30 12:42:25 PST
<rdar://problem/85881840>
Note You need to log in before you can comment on or make changes to this bug.