| Summary: | [WebXR] Implement ChromeClient API to allow getting explicit consent from user on session features | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||
| Component: | New Bugs | Assignee: | Ada Chan <adachan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, svillar, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ada Chan
2021-11-29 21:14:26 PST
Created attachment 445380 [details]
Patch
Comment on attachment 445380 [details] Patch The WebXR spec requires us to use the Permissions API https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned at some point that there was interest in implementing the Permissions API. Here you're using an ad-hoc solution via ChromeClient that should be replaced at some point by the permissions API variant. (In reply to Sergio Villar Senin from comment #2) > Comment on attachment 445380 [details] > Patch > > The WebXR spec requires us to use the Permissions API > https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned > at some point that there was interest in implementing the Permissions API. > > Here you're using an ad-hoc solution via ChromeClient that should be > replaced at some point by the permissions API variant. I'll add a FIXME about replacing that with the Permissions API. (In reply to Sergio Villar Senin from comment #2) > Comment on attachment 445380 [details] > Patch > > The WebXR spec requires us to use the Permissions API > https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned > at some point that there was interest in implementing the Permissions API. > > Here you're using an ad-hoc solution via ChromeClient that should be > replaced at some point by the permissions API variant. Yeah, we'll use this until we implement Permissions. Created attachment 445446 [details]
Patch for landing
Committed r286318 (244677@main): <https://commits.webkit.org/244677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445446 [details]. |