Bug 233604

Summary: Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, mifenton, sam, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233428    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Chris Dumez
Reported 2021-11-29 15:52:07 PST
Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks. Per the specification and to match the behavior of Blink & Gecko, ValidityState properties such as validity.typeMismatch should return true in case of mismatch even if the control is disabled (and thus willValidate() returns false).
Attachments
Patch (37.13 KB, patch)
2021-11-29 15:54 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (42.24 KB, patch)
2021-11-29 18:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (66.44 KB, patch)
2021-11-30 07:34 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (66.46 KB, patch)
2021-11-30 10:06 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-11-29 15:54:56 PST
Created attachment 445359 [details] Patch
Chris Dumez
Comment 2 2021-11-29 18:44:01 PST
Created attachment 445371 [details] Patch
Chris Dumez
Comment 3 2021-11-30 07:34:27 PST
Created attachment 445415 [details] Patch
Chris Dumez
Comment 4 2021-11-30 10:06:39 PST
Created attachment 445432 [details] Patch
EWS
Comment 5 2021-11-30 12:39:15 PST
Committed r286316 (244675@main): <https://commits.webkit.org/244675@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445432 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-30 12:40:22 PST
<rdar://problem/85881653>
Darin Adler
Comment 7 2021-11-30 12:51:34 PST
Noticed the misspelling "undeflow" is fairly common here.
Chris Dumez
Comment 8 2021-11-30 12:58:12 PST
(In reply to Darin Adler from comment #7) > Noticed the misspelling "undeflow" is fairly common here. Fixed in <https://commits.webkit.org/r286319>, thanks for noticing.
Note You need to log in before you can comment on or make changes to this bug.