| Summary: | AX: Reduce repetition in retrieving typed attribute values in AccessibilityUIElementMac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andresg_22, cfleizach, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 445358 [details]
Patch
tyler_w@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 445358 [details] from commit queue. Committed r286298 (244657@main): <https://commits.webkit.org/244657@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445358 [details]. |
We have a lot of functions in both the WebKitTestRunner and DumpRenderTree versions of AccessibilityUIElementMac that repeat the same logic for getting a typed attribute value. For example: bool AccessibilityUIElement::hasPopup() const { BEGIN_AX_OBJC_EXCEPTIONS id value = [m_element accessibilityAttributeValue:@"AXHasPopup"]; if ([value isKindOfClass:[NSNumber class]]) return [value boolValue]; END_AX_OBJC_EXCEPTIONS return false; }