Bug 233603

Summary: AX: Reduce repetition in retrieving typed attribute values in AccessibilityUIElementMac
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, cfleizach, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2021-11-29 15:45:56 PST
We have a lot of functions in both the WebKitTestRunner and DumpRenderTree versions of AccessibilityUIElementMac that repeat the same logic for getting a typed attribute value. For example: bool AccessibilityUIElement::hasPopup() const { BEGIN_AX_OBJC_EXCEPTIONS id value = [m_element accessibilityAttributeValue:@"AXHasPopup"]; if ([value isKindOfClass:[NSNumber class]]) return [value boolValue]; END_AX_OBJC_EXCEPTIONS return false; }
Attachments
Patch (28.58 KB, patch)
2021-11-29 15:51 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-29 15:46:22 PST
<rdar://problem/85838990>
Tyler Wilcock
Comment 2 2021-11-29 15:51:24 PST
Created attachment 445358 [details] Patch
EWS
Comment 3 2021-11-30 07:13:44 PST
tyler_w@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 445358 [details] from commit queue.
EWS
Comment 4 2021-11-30 08:20:10 PST
Committed r286298 (244657@main): <https://commits.webkit.org/244657@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445358 [details].
Note You need to log in before you can comment on or make changes to this bug.