Bug 233593

Summary: [JSC] slice should be aware of TerminationException
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2021-11-29 13:19:57 PST
[JSC] slice should be aware of terminated excution exception
Attachments
Patch (6.17 KB, patch)
2021-11-29 13:20 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-11-29 13:20:37 PST
Created attachment 445332 [details] Patch
Yusuke Suzuki
Comment 2 2021-11-29 13:20:42 PST
<rdar://problem/85823844>
Mark Lam
Comment 3 2021-11-29 13:29:31 PST
Comment on attachment 445332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445332&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + [JSC] slice should be aware of terminated excution exception It’s called a TerminationException now. Also, you had a typo in “excution”. > Source/JavaScriptCore/ChangeLog:9 > + Since terminated execution exception can happen at any time, assertNoException is wrong. Ditto. Please use “termination exception” instead. > JSTests/ChangeLog:9 > + * stress/slice-terminated-execution-exception.js: Added. I suggest renaming this to slice-termination-exception.js to match the new naming.
Yusuke Suzuki
Comment 4 2021-11-29 17:21:04 PST
Committed r286275 (244636@main): <https://commits.webkit.org/244636@main>
Note You need to log in before you can comment on or make changes to this bug.