Bug 233562

Summary: [css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, katherine_cheney, koivisto, kondapallykalyan, mrobinson, pdr, rbuis, rego, svillar, webkit-bug-importer, wenson_hsieh, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/32033
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sergio Villar Senin
Reported 2021-11-29 08:52:09 PST
[css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows
Attachments
Patch (3.42 KB, patch)
2021-11-29 08:52 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (4.11 KB, patch)
2021-11-29 09:03 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (7.69 KB, patch)
2021-12-13 07:01 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (7.69 KB, patch)
2021-12-13 07:22 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2021-11-29 08:52:47 PST
Created attachment 445282 [details] Patch
Sergio Villar Senin
Comment 2 2021-11-29 09:03:33 PST
Created attachment 445283 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-12-06 08:53:23 PST
<rdar://problem/86105904>
Sergio Villar Senin
Comment 4 2021-12-07 00:57:42 PST
Ping reviewers
Manuel Rego Casasnovas
Comment 5 2021-12-07 03:00:41 PST
Comment on attachment 445283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445283&action=review LGTM. > LayoutTests/TestExpectations:-4245 > -# The test works fine but the expected result fails due to a missing layout. It looks like we're fixing the reference but not the test itself. Could we add a new test (maybe unrelated to flexbox) that fails now and will pass with this patch?
Sergio Villar Senin
Comment 6 2021-12-08 00:53:19 PST
(In reply to Manuel Rego Casasnovas from comment #5) > Comment on attachment 445283 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445283&action=review > > LGTM. > > > LayoutTests/TestExpectations:-4245 > > -# The test works fine but the expected result fails due to a missing layout. > > It looks like we're fixing the reference but not the test itself. > > Could we add a new test (maybe unrelated to flexbox) that fails now and will > pass with this patch? Right. This is not a flexbox issue but an issue of how we handle margins in orthogonal flows with inline elements. I guess I could add some WPT test to css/css-writing-modes...
Sergio Villar Senin
Comment 7 2021-12-13 07:01:06 PST
Created attachment 447001 [details] Patch
EWS Watchlist
Comment 8 2021-12-13 07:02:16 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Sergio Villar Senin
Comment 9 2021-12-13 07:22:00 PST
Created attachment 447002 [details] Patch
EWS
Comment 10 2021-12-13 09:20:39 PST
Committed r286952 (245177@main): <https://commits.webkit.org/245177@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447002 [details].
Note You need to log in before you can comment on or make changes to this bug.