| Summary: | [css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cgarcia, changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, katherine_cheney, koivisto, kondapallykalyan, mrobinson, pdr, rbuis, rego, svillar, webkit-bug-importer, wenson_hsieh, youennf, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/32033 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Sergio Villar Senin
2021-11-29 08:52:09 PST
Created attachment 445282 [details]
Patch
Created attachment 445283 [details]
Patch
Ping reviewers Comment on attachment 445283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445283&action=review LGTM. > LayoutTests/TestExpectations:-4245 > -# The test works fine but the expected result fails due to a missing layout. It looks like we're fixing the reference but not the test itself. Could we add a new test (maybe unrelated to flexbox) that fails now and will pass with this patch? (In reply to Manuel Rego Casasnovas from comment #5) > Comment on attachment 445283 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445283&action=review > > LGTM. > > > LayoutTests/TestExpectations:-4245 > > -# The test works fine but the expected result fails due to a missing layout. > > It looks like we're fixing the reference but not the test itself. > > Could we add a new test (maybe unrelated to flexbox) that fails now and will > pass with this patch? Right. This is not a flexbox issue but an issue of how we handle margins in orthogonal flows with inline elements. I guess I could add some WPT test to css/css-writing-modes... Created attachment 447001 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 447002 [details]
Patch
Committed r286952 (245177@main): <https://commits.webkit.org/245177@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447002 [details]. |