| Summary: | Console Timing API does not contain space before duration when it gets printed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Max Schmitt <max> | ||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | bfulgham, eric.carlson, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, pangle, saam, tzagallo, webkit-bug-importer, youssefdevelops | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 445416 [details]
Patch
(In reply to Max Schmitt from comment #0) > There should be a space between the duration and the unit, see here in the spec: https://console.spec.whatwg.org/#timelog I dont think this is correct. The exact wording is > Let _duration_ be a string representing the difference between the current time and _startTime_, in an implementation-defined format. The only space that's required is between the `:` and the _duration_, which we already have. The example includes spaces, but that's just an example not required output. (In reply to Devin Rousso from comment #2) > (In reply to Max Schmitt from comment #0) > > There should be a space between the duration and the unit, see here in the spec: https://console.spec.whatwg.org/#timelog > > I dont think this is correct. The exact wording is > > > Let _duration_ be a string representing the difference between the current time and _startTime_, in an implementation-defined format. > > The only space that's required is between the `:` and the _duration_, which > we already have. The example includes spaces, but that's just an example > not required output. Thanks, Devin, the spec never explicitly mentions a space between the value and unit in _duration_. For example, in the latest Node.js release, the output is `MyTimer: 0.018ms`. Comment on attachment 445416 [details]
Patch
Our normal style in Web Inspector is to not have a space between the value and unit, so unless there's some compelling reason to do this I don't think we should break from our usual style.
|
```js console.time("MyTimer"); console.timeLog("MyTimer"); ``` Expected: ``` MyTimer: 0.018 ms ``` Actual: ``` MyTimer: 0.018ms ``` There should be a space between the duration and the unit, see here in the spec: https://console.spec.whatwg.org/#timelog