Bug 233528

Summary: [MSE] Fix erase range to prevent accidental deletion in files with changing durations
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alicia Boya García 2021-11-26 12:53:33 PST 
In didReceiveSample(), eraseBeginTime was being set to
highestPresentationTimestamp minus a tolerance. The tolerance is not
needed since highestPresentationTimestamp is loaded from exact frame
timestamps, and can cause accidental frame erasure in situations where
there are frames with frames smaller than the tolerance, which is the
case for certain MP4 files.

Test: media/media-source/media-source-append-tiny-durations.html
Comment 1 Alicia Boya García 2021-11-26 12:57:02 PST 
Created attachment 445208 [details]
Patch
Comment 2 EWS 2021-12-03 00:25:24 PST 
Committed r286485 (244824@main): <https://commits.webkit.org/244824@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445208 [details].